Skip to content

Conversation

jdconrad
Copy link
Contributor

@jdconrad jdconrad commented Sep 10, 2025

This updates the error message to use a "more like this" algorithm to suggest transport versions that may exist but are misspelled.

Unknown transport version [my_tranport_version].
Did you mean [my_transport_version]? 
If this is a new transport version, run './gradle generateTransportVersion'.

@jdconrad jdconrad added :Core/Infra/Transport API Transport client API >refactoring Team:Core/Infra Meta label for core/infra team auto-backport Automatically create backport pull requests when merged v9.2.0 v8.19.5 v9.1.5 v8.18.8 v9.0.8 labels Sep 10, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@mark-vieira
Copy link
Contributor

mark-vieira commented Sep 10, 2025

LGTM but the punctuation and formatting of this message is a bit wonky. Can we get something that looks a bit less like a text message from a teenager? For example:

Unknown transport version [my_tranport_version]. Did you mean [my_transport_version]?
If this is a new transport version, run './gradlew generateTransportVersion'.

@jdconrad
Copy link
Contributor Author

@mark-vieira I will fix the error message.

@jdconrad jdconrad merged commit 21c9c3e into elastic:main Sep 11, 2025
34 checks passed
jdconrad added a commit to jdconrad/elasticsearch that referenced this pull request Sep 11, 2025
This updates the error message to use a "more like this" 
algorithm to suggest transport versions that may exist but 
are misspelled.
jdconrad added a commit to jdconrad/elasticsearch that referenced this pull request Sep 11, 2025
This updates the error message to use a "more like this" 
algorithm to suggest transport versions that may exist but 
are misspelled.
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.19 Commit could not be cherrypicked due to conflicts
9.1
8.18 Commit could not be cherrypicked due to conflicts
9.0

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 134506

jdconrad added a commit to jdconrad/elasticsearch that referenced this pull request Sep 11, 2025
This updates the error message to use a "more like this"
algorithm to suggest transport versions that may exist but
are misspelled.
jdconrad added a commit to jdconrad/elasticsearch that referenced this pull request Sep 11, 2025
This updates the error message to use a "more like this"
algorithm to suggest transport versions that may exist but
are misspelled.
elasticsearchmachine pushed a commit that referenced this pull request Sep 11, 2025
)

* Improve missing tranport version error message (#134506)

This updates the error message to use a "more like this"
algorithm to suggest transport versions that may exist but
are misspelled.

* fix test
elasticsearchmachine pushed a commit that referenced this pull request Sep 11, 2025
This updates the error message to use a "more like this"
algorithm to suggest transport versions that may exist but
are misspelled.
elasticsearchmachine pushed a commit that referenced this pull request Sep 11, 2025
* Improve missing tranport version error message (#134506)

This updates the error message to use a "more like this" 
algorithm to suggest transport versions that may exist but 
are misspelled.

* fix tests
elasticsearchmachine pushed a commit that referenced this pull request Sep 11, 2025
* Improve missing tranport version error message (#134506)

This updates the error message to use a "more like this" 
algorithm to suggest transport versions that may exist but 
are misspelled.

* fix tests
sarog pushed a commit to portsbuild/elasticsearch that referenced this pull request Sep 19, 2025
elastic#134562)

* Improve missing tranport version error message (elastic#134506)

This updates the error message to use a "more like this"
algorithm to suggest transport versions that may exist but
are misspelled.

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged backport pending :Core/Infra/Transport API Transport client API >refactoring Team:Core/Infra Meta label for core/infra team v8.18.8 v8.19.5 v9.0.8 v9.1.5 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants